-
Notifications
You must be signed in to change notification settings - Fork 44
feat: set-version at publish task #3681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
508be60 to
d9fd73e
Compare
|
View your CI Pipeline Execution ↗ for commit 5a7c704
☁️ Nx Cloud last updated this comment at |
8e8c3e6 to
7b382df
Compare
7b382df to
6b1f15e
Compare
4c2230d to
a1b9945
Compare
| "build:swagger-gen": "yarn nx run-many --target=build-swagger", | ||
| "publish": "yarn nx run-many --target=prepare-publish --exclude-task-dependencies && yarn nx run-many --target=publish --exclude=tag:private", | ||
| "publish:extensions": "yarn nx run-many --target=prepare-publish --exclude-task-dependencies && yarn nx run-many --target=publish-extension", | ||
| "publish": "yarn nx run-many --target=publish --exclude=tag:private", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's going to rebuild everything on release branches where the cache is disabled, not ideal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the disable remote cache is a scenario to take in consideration, I will add a local cache transmission mechanism but factually the publish task requires the build task to be run before so the this dependency should remain to avoid mutated dist folder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we actually disable the cache entirely on releases, not just remote cache
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have then changed from local cache disabling to a remote cache only
f434d0e to
b1d1368
Compare
510e4ce to
4b3ab98
Compare
4b3ab98 to
5a7c704
Compare
Proposed change
feat: set-version at publish task
Related issues
- No issue associated -