Skip to content

Conversation

@kpanot
Copy link
Contributor

@kpanot kpanot commented Nov 4, 2025

Proposed change

feat: set-version at publish task

Related issues

- No issue associated -

@kpanot kpanot force-pushed the feature/publish-with-version branch from 508be60 to d9fd73e Compare November 4, 2025 10:29
@nx-cloud
Copy link

nx-cloud bot commented Nov 4, 2025

View your CI Pipeline Execution ↗ for commit 5a7c704

Command Status Duration Result
nx run-many --target=test-e2e ✅ Succeeded 2m View ↗
nx run-many --target=build --projects=eslint-pl... ✅ Succeeded 1s View ↗
nx affected --target=test --collectCoverage --c... ✅ Succeeded 10m 32s View ↗
nx run-many --target=build,build-swagger ✅ Succeeded 17m 9s View ↗
nx affected --target=lint --configuration ci ✅ Succeeded 16m 42s View ↗
nx run ama-sdk-schematics:build-swagger ✅ Succeeded 4m 46s View ↗
nx run-many --target=documentation ✅ Succeeded 1m 32s View ↗
nx affected --target=package-github-action ✅ Succeeded 2m 10s View ↗

☁️ Nx Cloud last updated this comment at 2025-11-11 00:59:18 UTC

@kpanot kpanot force-pushed the feature/publish-with-version branch 2 times, most recently from 8e8c3e6 to 7b382df Compare November 4, 2025 17:02
@kpanot kpanot force-pushed the feature/publish-with-version branch from 7b382df to 6b1f15e Compare November 4, 2025 17:23
@kpanot kpanot marked this pull request as ready for review November 4, 2025 17:23
@kpanot kpanot requested a review from a team as a code owner November 4, 2025 17:23
@kpanot kpanot force-pushed the feature/publish-with-version branch 4 times, most recently from 4c2230d to a1b9945 Compare November 4, 2025 23:38
"build:swagger-gen": "yarn nx run-many --target=build-swagger",
"publish": "yarn nx run-many --target=prepare-publish --exclude-task-dependencies && yarn nx run-many --target=publish --exclude=tag:private",
"publish:extensions": "yarn nx run-many --target=prepare-publish --exclude-task-dependencies && yarn nx run-many --target=publish-extension",
"publish": "yarn nx run-many --target=publish --exclude=tag:private",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's going to rebuild everything on release branches where the cache is disabled, not ideal

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the disable remote cache is a scenario to take in consideration, I will add a local cache transmission mechanism but factually the publish task requires the build task to be run before so the this dependency should remain to avoid mutated dist folder

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we actually disable the cache entirely on releases, not just remote cache

Copy link
Contributor Author

@kpanot kpanot Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have then changed from local cache disabling to a remote cache only

@kpanot kpanot force-pushed the feature/publish-with-version branch 4 times, most recently from f434d0e to b1d1368 Compare November 5, 2025 16:10
@kpanot kpanot removed the runAllTests label Nov 5, 2025
@kpanot kpanot force-pushed the feature/publish-with-version branch 10 times, most recently from 510e4ce to 4b3ab98 Compare November 10, 2025 14:37
@kpanot kpanot force-pushed the feature/publish-with-version branch from 4b3ab98 to 5a7c704 Compare November 11, 2025 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request project:@ama-mcp/angular project:@ama-mcp/core project:@ama-mcp/github project:@ama-mcp/otter project:@ama-mfe/messages project:@ama-mfe/ng-utils project:@ama-sdk/client-angular project:@ama-sdk/client-beacon project:@ama-sdk/client-fetch project:@ama-sdk/core project:@ama-sdk/create project:@ama-sdk/schematics project:@ama-sdk/swagger-builder project:@ama-styling/figma-extractor project:@ama-styling/figma-sdk project:@ama-styling/style-dictionary project:@ama-styling/stylelint-plugin project:@ama-terasu/cli project:@ama-terasu/core project:@ama-terasu/schematics project:@o3r/amaterasu-api-spec project:@o3r/amaterasu-dodo project:@o3r/amaterasu-otter project:@o3r/amaterasu-sdk project:@o3r/analytics project:@o3r/apis-manager project:@o3r/application project:@o3r/artifactory-tools project:@o3r/azure-tools project:@o3r/chrome-devtools project:@o3r/components project:@o3r/configuration project:@o3r/core project:@o3r/create project:@o3r/design project:@o3r/dynamic-content project:@o3r/eslint-config project:@o3r/eslint-plugin project:@o3r/extractors project:@o3r/forms project:@o3r/localization project:@o3r/logger project:@o3r/mcp project:@o3r/mobile project:@o3r/new-version project:@o3r/pipeline project:@o3r/routing project:@o3r/rules-engine project:@o3r/schematics project:@o3r/store-sync project:@o3r/style-dictionary project:@o3r/stylelint-plugin project:@o3r/styling project:@o3r/telemetry project:@o3r/testing project:@o3r/third-party project:@o3r/workspace project:@o3r-training/showcase-sdk project:otter-devtools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants