Skip to content

internal_replication should be false, if there is a single replica. #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 16, 2020
Merged

internal_replication should be false, if there is a single replica. #422

merged 1 commit into from
Jun 16, 2020

Conversation

yuzhichang
Copy link
Contributor

Fix #421

@alex-zaitsev
Copy link
Member

Thanks, we already planned it for 0.10.0 release, so this PR is just in time.

@sunsingerus sunsingerus self-requested a review June 10, 2020 11:40
@sunsingerus sunsingerus self-assigned this Jun 10, 2020
@sunsingerus
Copy link
Collaborator

merged into https://github.com/Altinity/clickhouse-operator/tree/0.10.0

@sunsingerus sunsingerus merged commit d98fb70 into Altinity:master Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunsingerus sunsingerus sunsingerus approved these changes

Assignees

@sunsingerus sunsingerus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

User-specified shards-only clusters shard.internal_replication is true
3 participants
@yuzhichang @alex-zaitsev @sunsingerus