Add a "secure" option for Zookeeper Node #1114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunsingerus
requested changes
Feb 27, 2023
deploy/operator/parts/crd.yaml
Outdated
| minimum: 0 | ||
| maximum: 65535 | ||
| secure: | ||
| type: integer |
There was a problem hiding this comment.
- Looks like attempt to make bool out of int type. Probably it would be more proper to use StringBool type in here
- crd.yaml is a generated file and not supposed to be edited manually
There was a problem hiding this comment.
- Changed to StringBool.
- CRD were generated.
pkg/model/ch_config_generator.go
Outdated
| util.Iline(b, 8, "<node>") | ||
| util.Iline(b, 8, " <host>%s</host>", node.Host) | ||
| util.Iline(b, 8, " <port>%d</port>", node.Port) | ||
| if node.Secure == 1 { |
There was a problem hiding this comment.
making bool out of int looks a little awkward
There was a problem hiding this comment.
Changed to node.Secure.HasValue() method
Signed-off-by: Aleksandr Ivanov <[email protected]>
sunsingerus
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for taking the time to contribute to
clickhouse-operator!Please, read carefully instructions on how to make a Pull Request.
This will help a lot for maintainers to adopt your Pull Request.
Important items to consider before making a Pull Request
Please check items PR complies to:
next-releasebranch, not intomasterbranch1. More info--
1 If you feel your PR does not affect any Go-code or any testable functionality (for example, PR contains docs only or supplementary materials), PR can be made into
masterbranch, but it has to be confirmed by project's maintainer.