Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might fix #4244
The cava module bars always peak at maximum regardless of sensitivity settings. This is caused by
audio_raw_init()overwritingaudio_raw_.heightwith an incorrect value.After PR #4682 refactored cava into frontend/backend architecture,
audio_raw_.heightis set toprm_.ascii_range(the number of format-icons minus 1), but thenaudio_raw_init()overwrites it. This causesaudio_raw_fetch()to scale bars incorrectly, resulting in values like 20000+ instead of the expected 0-7 range.Simply set
audio_raw_.height = prm_.ascii_rangeafter callingaudio_raw_init()to preserve the correct height value.fix(cava): restore ascii_range height after audio_raw_init
audio_raw_init() overwrites audio_raw_.height, causing bars to display
incorrect values. Set height to prm_.ascii_range after init to ensure
proper bar scaling within the configured format-icons range.