Add '-<state>' support to wifi config #4722
Open
+10
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most modules support config fields like "format-<status>-<state>", so the user can, for example, set a different format for batter when unplugged _and_ under a given level. Wifi didn't support this. Change the module to support format state based on signal strength.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most modules support config fields like "format--", so the user can, for example, set a different format for batter when unplugged and under a given level. Wifi didn't support this, only supporting what the waybar-states man page calls a "status". Add state support so users can set a format for "format-wifi-critical", for example.
Side note, the terminology is a bit mixed here. Would you prefer I try to make the state -> status thing a bit more consistent in the wifi module? Maybe renaming getNetworkState and the vars. It seems like battery follows this convention at least. I opted for the minimal diff for this PR