Encode icon inside label #4719
Open
Encode icon inside label #4719
+52
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR its possible to encode icons using label string.
This would allow modules inherits AIconLabel instead of ALabel and having icons encoded inside
formatand/orformat-iconsin config file.Rofi’s extended dmenu protocol is used to encode icon metadata, which starts with
\0icon\1ffollowed by named icon or path to an image and ended with\n. Because of config file will be decoded as JSON then it should written\\0icon\\1f<icon-name>\\nin config file strings.Currently only one icon per label allowed, this PR will take first found pattern as icon and ignore the rest.
icon-sizekey in config will be used to determine icon size if a path to an image file being supplied. This key is ignored if a named icon being used.