Add stretching of modules and modules-center toggling #3730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Any Interest in looking at this? The 51 come from touching nearly all man pages. |
This Patch allows the stretching of modules-{left,center,right} as well
add a "expand" flag to AModule. This allows one module to consume the
leftover space.
To allow the left or right modules to fully consume the center, the
changes also include a way to remove the center box (center_)
altogether.
TripleTrable
force-pushed
the
AModuls/expand-fill-no-center
branch
from
1fa0a8b to
1e481b7
Compare
Owner
|
LGTM, thx! |
tmccombs
reviewed
Dec 31, 2024
tmccombs
reviewed
Jan 1, 2025
tmccombs
added a commit
to tmccombs/Waybar
that referenced
this pull request
Jan 1, 2025
Resolving conflicts with f9acc1f (Alexays#3730) was a somewhat complicated. Conflicts: include/AModule.hpp src/AModule.cpp src/bar.cpp src/modules/network.cpp src/util/backlight_backend.cpp
TripleTrable
added a commit
to TripleTrable/Waybar
that referenced
this pull request
Jan 13, 2025
Thanks to tmccombs this commit fixes some inconsitencies in Alexays#3730. These inconsitencies were: - Fixed the oversight of missing the implementation of expand_center for center_ and right_ - Removes a last minut printf debugging statment I missed.
TripleTrable
added a commit
to TripleTrable/Waybar
that referenced
this pull request
Mar 9, 2025
Thanks to tmccombs this commit fixes some inconsitencies in Alexays#3730. These inconsitencies were: - Fixed the oversight of missing the implementation of expand_center for center_ and right_ - Removes a last minut printf debugging statment I missed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Patch allows the stretching of modules-{left,center,right} as well add a "expand" flag to AModule. This allows one module to consume the leftover space.
To allow the left or right modules to fully consume the center, the changes also include a way to remove the center box (center_) altogether.
This is useful for use-cases like: #1561