🛡️ Sentinel: [MEDIUM] Fix missing noopener,noreferrer in window.open#180
🛡️ Sentinel: [MEDIUM] Fix missing noopener,noreferrer in window.open#180Alesiobarquin wants to merge 1 commit into
Conversation
Co-authored-by: Alesiobarquin <156465247+Alesiobarquin@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning Review limit reached
More reviews will be available in 47 minutes and 49 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
🚨 Severity: MEDIUM
💡 Vulnerability: The
window.opencall inMockInterview.tsxwas opening external URLs in a new tab (_blank) withoutnoopener,noreferrer. This exposes the application to potential reverse tabnabbing attacks, where the newly opened window could malicious manipulate thewindow.openerobject to redirect the parent page to a phishing site.🎯 Impact: If
leetcodeUrlornewProblemData.leetcodeUrlcould ever be user-controlled or compromised, it could lead to phishing or unauthorized redirection of the main application window.🔧 Fix: Added
'noopener,noreferrer'as the third argument to thewindow.opencall.✅ Verification: Verified fix through local testing and automated checks (
pnpm testandpnpm lint). Recorded learning in.jules/sentinel.md.PR created automatically by Jules for task 11206161566471823763 started by @Alesiobarquin