Skip to content

Extend the index parameters to support the float type #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 15, 2024
Merged

Extend the index parameters to support the float type #74

merged 1 commit into from
Jul 15, 2024

Conversation

laojianzi
Copy link
Contributor

@laojianzi laojianzi commented Jul 15, 2024 •
edited
Loading

extend the index parameters to support the float type and add parsing index tests for ALTER TABLE ... ADD INDEX and CREATE TABLE ... INDEX

index types ref: https://clickhouse.com/docs/en/optimize/skipping-indexes#skip-index-types

  • minmax
  • set
  • bloom_filter
  • tokenbf_v1
  • ngrambf_v1

@coveralls
Copy link

Pull Request Test Coverage Report for Build 9937319416

Details

  • 7 of 7 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 58.064%
Totals Coverage Status
Change from base Build 9866858946: 0.07%
Covered Lines: 5897
Relevant Lines: 10156
💛 - Coveralls

@git-hulk git-hulk changed the title feat: support for more index(minmax/set/bloom_filter/tokenbf_v1/ngrambf_v1) parsing Extend the index parameters to support the float type Jul 15, 2024
git-hulk
git-hulk approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@git-hulk git-hulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@git-hulk git-hulk merged commit 666418f into AfterShip:master Jul 15, 2024
git-hulk pushed a commit to git-hulk/clickhouse-sql-parser that referenced this pull request Nov 29, 2024
@laojianzi @git-hulk
Extend the index parameters to support the float type (AfterShip#74)
4f4a0c6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@git-hulk git-hulk git-hulk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laojianzi @coveralls @git-hulk