Skip to content

Fix should skip spaces before parsing the comment line #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2024
Merged

Fix should skip spaces before parsing the comment line #66

merged 1 commit into from
May 7, 2024

Conversation

git-hulk
Copy link
Member

@git-hulk git-hulk commented May 7, 2024

This close #65

@git-hulk git-hulk requested a review from Lance726 May 7, 2024 02:34
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8978801224

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 57.755%
Files with Coverage Reduction New Missed Lines %
parser/lexer.go 3 95.11%
Totals Coverage Status
Change from base Build 8535005604: -0.02%
Covered Lines: 5846
Relevant Lines: 10122
💛 - Coveralls

@git-hulk git-hulk merged commit c838854 into AfterShip:master May 7, 2024
@git-hulk git-hulk deleted the fix/multi-line-comments branch November 29, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lance726 Lance726 Lance726 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to parse comment lines under certain circumstances
3 participants
@git-hulk @coveralls @Lance726