Skip to content

Allow to use string as database/table name #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2024
Merged

Allow to use string as database/table name #52

merged 1 commit into from
Feb 27, 2024

Conversation

git-hulk
Copy link
Member

@git-hulk git-hulk commented Feb 27, 2024 •
edited
Loading

This closes #46

@git-hulk git-hulk requested a review from Lance726 February 27, 2024 09:41
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8062640550

Details

  • -5 of 20 (75.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 56.899%
Changes Missing Coverage Covered Lines Changed/Added Lines %
parser/ast.go 2 7 28.57%
Totals Coverage Status
Change from base Build 8062506682: 0.03%
Covered Lines: 5476
Relevant Lines: 9624
💛 - Coveralls

@git-hulk git-hulk merged commit a13d22d into AfterShip:master Feb 27, 2024
@git-hulk git-hulk deleted the fix/string-as-table-ident branch November 29, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lance726 Lance726 Lance726 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Syntax Compatibility] TableIdentifier does not support double quotes
3 participants
@git-hulk @coveralls @Lance726