Skip to content

Fix cannot alias column with the literal string #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2024
Merged

Fix cannot alias column with the literal string #51

merged 1 commit into from
Feb 27, 2024

Conversation

git-hulk
Copy link
Member

This closes #48

@git-hulk git-hulk requested a review from Lance726 February 27, 2024 09:27
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8062464072

Details

  • -2 of 12 (83.33%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 56.867%
Changes Missing Coverage Covered Lines Changed/Added Lines %
parser/parser_common.go 6 8 75.0%
Totals Coverage Status
Change from base Build 8062330709: 0.0%
Covered Lines: 5474
Relevant Lines: 9626
💛 - Coveralls

@git-hulk git-hulk merged commit 1daecf8 into AfterShip:master Feb 27, 2024
@git-hulk git-hulk deleted the fix/column-alias-string branch November 29, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lance726 Lance726 Lance726 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Syntax Compatibility] Column aliases do not support double quotes
3 participants
@git-hulk @coveralls @Lance726