Skip to content

Conversation

git-hulk
Copy link
Member

This closes #145.

@git-hulk git-hulk requested review from Copilot and Lance726 April 17, 2025 12:23
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the issue of using keywords as column names by updating the parser behavior. Key changes include:

  • Adding a new function (peekKeyword) to check if the next token matches a given keyword.
  • Modifying the parseColumnExpr function to parse a keyword as an identifier when followed by a comma or the AS keyword.
Files not reviewed (3)
  • parser/testdata/query/format/select_with_keyword_in_group_by.sql: Language not supported
  • parser/testdata/query/output/select_with_keyword_in_group_by.sql.golden.json: Language not supported
  • parser/testdata/query/select_with_keyword_in_group_by.sql: Language not supported

@coveralls
Copy link

Pull Request Test Coverage Report for Build 14515538497

Details

  • 14 of 14 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 62.758%

Totals Coverage Status
Change from base Build 14514766397: 0.08%
Covered Lines: 6889
Relevant Lines: 10977

💛 - Coveralls

@git-hulk git-hulk merged commit 5b640ce into AfterShip:master Apr 18, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why does this fail (is it because of conflict with interval as result alias?)
3 participants