Skip to content

Conversation

orian
Copy link
Contributor

@orian orian commented Mar 2, 2025

ClickHouse allows to not use AS keyword when naming selected columns:

SELECT col1 AS one, col2 two
FROM tbl

Fix it.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 13620153978

Details

  • 14 of 14 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 60.841%

Totals Coverage Status
Change from base Build 13580367952: 0.06%
Covered Lines: 6541
Relevant Lines: 10751

💛 - Coveralls

Copy link
Member

@git-hulk git-hulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@git-hulk git-hulk merged commit 62ed1c8 into AfterShip:master Mar 3, 2025
1 check passed
@orian orian deleted the fix-no-as-alias branch March 3, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants