ALTER TABLE doesn't support MODIFY SETTING syntax

[git-hulk]

ClickHouse MODIFY|RESET syntax:

ALTER TABLE [db].name [ON CLUSTER cluster] MODIFY|RESET SETTING ...

Example:

ALTER TABLE example_table MODIFY SETTING max_part_loading_threads=8, max_parts_in_total=50000;

ALTER TABLE example_table RESET SETTING max_part_loading_threads;

Remember to use make update_test to update test cases. Reuse existing code as much as possible.

[git-hulk]

@claude Please read the issue and implement the solution.

[claude]

Claude finished @git-hulk's task —— View job • claude/issue-184-20250827-0341 • Create PR ➔

---

✅ ALTER TABLE MODIFY/RESET SETTING syntax implementation complete

I've successfully implemented support for the ALTER TABLE MODIFY/RESET SETTING syntax as requested.

Todo List:

• Examine existing ALTER TABLE parsing implementation
• Design AST nodes for MODIFY/RESET SETTING operations
• Implement parsing logic for new syntax
• Add comprehensive test cases
• Update golden test files using make update_test
• Run tests and linting to verify implementation
• Commit and push changes

🚀 Implementation Summary

New Keywords Added:

• RESET - For reset syntax
• SETTING (singular) - For both modify and reset syntax

New AST Nodes:

• AlterTableModifySetting - Handles MODIFY SETTING key=value, key2=value2
• AlterTableResetSetting - Handles RESET SETTING key1, key2, key3

Parsing Support:

• Extended parseAlterTableModify() to handle SETTING keyword
• Added parseAlterTableReset() for RESET SETTING syntax
• Added parseSettingsExprOnly() helper for parsing settings without SETTINGS keyword
• Full visitor pattern and walk pattern support

Test Cases Added:

• alter_table_modify_setting.sql - Basic modify setting test
• alter_table_reset_setting.sql - Single setting reset
• alter_table_reset_multiple_settings.sql - Multiple settings reset

Supported Syntax:
✅ ALTER TABLE example_table MODIFY SETTING max_part_loading_threads=8, max_parts_in_total=50000;
✅ ALTER TABLE example_table RESET SETTING max_part_loading_threads;
✅ ALTER TABLE example_table RESET SETTING key1, key2, key3;

The implementation follows the existing codebase patterns and should work seamlessly with the current parser architecture. All changes have been committed and pushed to the branch.

---