PayPal overlay persists after action.reject()

[ayubov]

Describe the bug
When a user clicks the PayPal button, we make an API call to our backend. If an error occurs, we invoke actions.reject() on the SubmitActions object within the onSubmit callback. While this correctly closes the PayPal popup, the corresponding overlay remains in the DOM.

To Reproduce

1. Open PayPal popup
2. Call actions.reject() inside onSubmit callback
3. Observe that the PayPal popup closes, but its overlay remains in the DOM

Expected behavior
Overlay should disappear when popup is closing

Screenshots

Desktop (please complete the following information):

• Browser Chrome

Additional context
Reproducible with the latest adyen-web version

[ribeiroguilherme]

Hi @ayubov ,

Thanks for reaching out. We will take a look into it.

Just to confirm - by the screenshot we can see that the overlay is still in the DOM, but by the website look it seems that it is "gone" and it is not actually disrupting the payment part. Can you confirm if that is the case?

[ayubov]

Hey @ribeiroguilherme!

It does disrupt the payment process, as the UI becomes unclickable due to the overlay.

[stoufax]

I agree, I have the same issue. It also happens when closing the pop-up directly before the action is handled.

[frno-morita]

@ribeiroguilherme
This seems to mostly be an issue of not correctly calling the Promise rejection when errors happen. https://github.com/Adyen/adyen-web/blob/main/packages/lib/src/components/PayPal/Paypal.tsx#L186-L193.

A workaround could be to keep track of this in the onPaymentFailed callback and check if the active payment method that triggered this was PayPal. You can then call handleReject for PayPal which will properly tell PayPal that the onSubmit was rejected with an error which in turn removes the overlay and cleans up.

Does this make sense or am I missing something?

[johnayeni]

This issue would be fixed on this release

[frno-morita]

Good to have this fixed finally @johnayeni!

[johnayeni]

Issue has been addressed in this release. Closing this issue.