[PW-7810] Create templates for small services#202
Merged
Conversation
antolo-arch
requested review from
AlexandrosMor,
acampos1916,
candemiralp,
jillingk,
michaelpaul,
rikterbeek and
wboereboom
as code owners
wboereboom
reviewed
Jan 24, 2023
| openapi-generator-cli:=java -jar build/openapi-generator-cli.jar | ||
| services:=balancePlatform binlookup checkout dataProtection legalEntityManagement management payments payouts platformsAccount platformsFund platformsHostedOnboardingPage platformsNotificationConfiguration recurring storedValue terminalManagement transfer | ||
| services:=balancePlatform checkout legalEntityManagement management payments payouts platformsAccount platformsFund platformsHostedOnboardingPage platformsNotificationConfiguration terminalManagement transfer | ||
| smallServices:= recurring binlookup dataProtection storedValue balanceControlService |
Contributor
There was a problem hiding this comment.
could be alphabetic order 🤷
Contributor
Author
There was a problem hiding this comment.
Will fix that in the next PR!
wboereboom
approved these changes
Jan 24, 2023
jillingk
approved these changes
Jan 24, 2023
| @@ -1,4 +1,3 @@ | |||
| {{>partial_header}} | |||
Contributor
There was a problem hiding this comment.
Why is the partial header removed? Does the api-small class extend the api.mustache class or smth?
Contributor
Author
There was a problem hiding this comment.
not to include the header in all the classes as it's generated for each subclass, small one is generated once, thus the header stays there
Contributor
There was a problem hiding this comment.
ahh okay, so only the init files in the big services have that header?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Templates for smaller services
Tested scenarios
Tested locally, generated services will be tested in different PRs