Client: Respect timeout across all services#151
Merged
AlexandrosMor merged 1 commit intoOct 18, 2021
Merged
Conversation
ohadbenita
requested review from
Aleffio,
AlexandrosMor,
acampos1916,
martinsrenato and
rikterbeek
as code owners
Contributor
Author
|
@Aleffio this bug is hurting our backend services in China. Due to high latency reaching Adyen's services from mainland China, we've set an aggressive 5 seconds timeout on all calls to Adyen's endpoint (we mostly use the Checkout API endpoint). As you can see from these changes, the timeout isn't respected in the Checkout API as well as hpp and others. I'd be thankful if you could review this PR and issue a release soon. Thanks |
Contributor
Author
|
@Aleffio @AlexandrosMor @rikterbeek Can you please take a look into this? |
Merged
AlexandrosMor
approved these changes
Oct 18, 2021
acampos1916
approved these changes
Oct 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Respect the timeout setting for all services. Up until now, in some services
self.http_timeoutwasn't part of the kwargs and therefore the timeout passed to the client wasn't respected.