Fix fetching proper configuration#3298
Open
mtytula wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the store ID assignment logic in Controller/Return/Index.php to ensure the correct store context is used when retrieving redirect configurations. The review feedback identifies redundant ternary operations in both instances where $storeId is updated, recommending direct assignments to improve code clarity and efficiency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix redirect configuration being fetched from the wrong store when the current store context differs from the order's store.
The $storeId was initialized from $this->storeManager->getStore()->getId(), which reflects the current store context at the time of the return request — not necessarily the store the order was placed on. In multi-store setups (e.g.
different store views per language/region), this caused custom_success_redirect_path and return_path to be read from the wrong store's configuration.
Two corrections applied in Controller/Return/Index.php:
Tested scenarios
Fixes
#3299