[ECP-9938] Support Magento 2.4.9 and PHP 8.5#3278
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on updating the module to ensure compatibility with Magento 2.4.9 and PHP 8.5. It includes a return type declaration update in command files and a modification to the composer.json file to allow PHP 8.5. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
The pull request successfully updates the return type declarations for the execute methods in EnablePaymentMethodsCommand.php and WebhookProcessorCommand.php to explicitly return int. Additionally, it extends PHP compatibility in composer.json to include PHP 8.5. These changes improve type safety and broaden the supported PHP versions, aligning with modern development practices and the stated objective of supporting Magento 2.4.9 and PHP 8.5.
|



Description
This PR fixes the
Symfony\Component\Console\Command\Commandinterface compatibility required for supporting Magento 2.4.9. Besides that, PHP 8.5 compatibility has been introduced.Tested scenarios