Skip to content

[ECP-9938] Support Magento 2.4.9 and PHP 8.5#3278

Merged
candemiralp merged 2 commits into
mainfrom
ECP-9938
Mar 23, 2026
Merged

[ECP-9938] Support Magento 2.4.9 and PHP 8.5#3278
candemiralp merged 2 commits into
mainfrom
ECP-9938

Conversation

@candemiralp

@candemiralp candemiralp commented Mar 23, 2026

Copy link
Copy Markdown
Contributor

Description

This PR fixes the Symfony\Component\Console\Command\Command interface compatibility required for supporting Magento 2.4.9. Besides that, PHP 8.5 compatibility has been introduced.

Tested scenarios

  • Wallet payments
  • Card payments w/wo 3DS2
  • Recurring payments
  • MOTO
  • Pay by Link
  • Headless integration (REST + GraphQl)
  • Gift card payments
  • Magento 2.4.8 compatibility

@candemiralp candemiralp requested a review from a team as a code owner March 23, 2026 10:09
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on updating the module to ensure compatibility with Magento 2.4.9 and PHP 8.5. It includes a return type declaration update in command files and a modification to the composer.json file to allow PHP 8.5.

Highlights

  • Magento 2.4.9 Support: This PR introduces compatibility fixes required for supporting Magento 2.4.9.
  • PHP 8.5 Compatibility: The PR also introduces compatibility with PHP 8.5.
  • Command Return Types: The execute methods in EnablePaymentMethodsCommand.php and WebhookProcessorCommand.php were updated to declare an integer return type.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request successfully updates the return type declarations for the execute methods in EnablePaymentMethodsCommand.php and WebhookProcessorCommand.php to explicitly return int. Additionally, it extends PHP compatibility in composer.json to include PHP 8.5. These changes improve type safety and broaden the supported PHP versions, aligning with modern development practices and the stated objective of supporting Magento 2.4.9 and PHP 8.5.

@candemiralp candemiralp changed the title [ECP-9938] Support Magento 2.4.9 [ECP-9938] Support Magento 2.4.9 and PHP 8.5 Mar 23, 2026
@sonarqubecloud

Copy link
Copy Markdown

@candemiralp candemiralp merged commit 008a71e into main Mar 23, 2026
9 of 10 checks passed
@candemiralp candemiralp deleted the ECP-9938 branch March 23, 2026 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants