Fixed order payment saving#2557
Open
mtytula wants to merge 5 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I discovered an issue with processing webhook notifications. This problem occurs when adyen is trying to send the same webhook notification to magento and they are duplicated. During webhook processing something goes wrong and one notification saved data in adyen_order_payment table. Next notification tries to save the same data but there is a unique constraint added to pspreference column and the whole notification is not processed and order status is changing to processing without changing total paid data on order.
The problem occurs on Magento 2.4.5-p6 with 8.18.1 adyen/module-payment module
Tested scenarios
Duplicate notifications for one order and rund webhook handler. It will catch an error about unique constraint violation without my fix.