Skip to content

StoredCardInputViewController: Fix CVV validation by resigning first responder (5.2/6)#2543

Open
robertdalmeida wants to merge 3 commits into
developfrom
chore/stored-view-validation-bug
Open

StoredCardInputViewController: Fix CVV validation by resigning first responder (5.2/6)#2543
robertdalmeida wants to merge 3 commits into
developfrom
chore/stored-view-validation-bug

Conversation

@robertdalmeida
Copy link
Copy Markdown
Contributor

@robertdalmeida robertdalmeida commented May 12, 2026

Summary [Required]

Fix bug 🐞 Validation issue with the FormCardSecurityItem - it accepts 4 digits even though UI accepts only 3.

Behaviour same as CardComponent - When the user enters the cvv code and reaches the max limit then it automatically resigns responder so the possibility of validation error is avoided.

Whats next?

Fix bug 🐞 Constraints issue with the FormCardSecurityCodeItemView.

Previous MR - #2506

Ticket [Optional]

COSDK-1140

Checklist [Required]

  • Tested changes locally
  • Added/updated unit tests

@robertdalmeida robertdalmeida self-assigned this May 12, 2026
@robertdalmeida robertdalmeida added the chore a pull request that has chore changes that shouldn't be in the release notes label May 12, 2026
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 12, 2026

ℹ️ No baseline data found for 'develop'.

Framework Size
AdyenComponents.framework 2844 KB
AdyenActions.framework 2351 KB
AdyenDropIn.framework 1362 KB
AdyenDelegatedAuthentication.framework 98 KB
AdyenAuthentication.framework 347 KB
AdyenWeChatPay.framework 262 KB
AdyenUI.framework 3314 KB
AdyenCardScanner.framework 694 KB
AdyenEncryption.framework 504 KB
AdyenSession.framework 651 KB
AdyenTwint.framework 277 KB
AdyenWeChatPayInternal.framework 4135 KB
AdyenCheckout.framework 2150 KB
AdyenCashAppPay.framework 1764 KB
AdyenCard.framework 1719 KB
TwintSDK.framework 97 KB
Adyen3DS2.framework 919 KB
Adyen.framework 5075 KB
total 28563 KB

@robertdalmeida
Copy link
Copy Markdown
Contributor Author

/gemini review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enhances the security code input behavior in StoredCardInputViewController by managing focus states and implementing the FormTextItemViewDelegate. Key changes include automatically focusing the input field on load, resigning focus upon reaching the maximum character length, and adding integration tests for these behaviors. Feedback suggests improving encapsulation by avoiding direct access to the internal text field and enhancing the user experience by triggering the primary action when the return key is pressed.

@github-actions
Copy link
Copy Markdown
Contributor

✅ No changes detected

Comparing chore/stored-view-validation-bug to develop
Platform: iOS


Analyzed targets: Adyen, AdyenActions, AdyenCard, AdyenCardScanner, AdyenCashAppPay, AdyenCheckout, AdyenComponents, AdyenDelegatedAuthentication, AdyenDropIn, AdyenEncryption, AdyenSession, AdyenSwiftUI, AdyenTwint, AdyenUI, AdyenWeChatPay

@robertdalmeida robertdalmeida marked this pull request as ready for review May 13, 2026 08:47
@robertdalmeida robertdalmeida changed the title COSDK-1140 StoredCardInputViewController fixed bug 🐞 resign responder when the cvv code is entered (5.2/6) COSDK-1140: StoredCardInputViewController: Fix CVV validation by resigning first responder (5.2/6) May 13, 2026
@robertdalmeida robertdalmeida changed the title COSDK-1140: StoredCardInputViewController: Fix CVV validation by resigning first responder (5.2/6) StoredCardInputViewController: Fix CVV validation by resigning first responder (5.2/6) May 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore a pull request that has chore changes that shouldn't be in the release notes size:tiny

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants