StoredCardInputViewController: Fix CVV validation by resigning first responder (5.2/6)#2543
StoredCardInputViewController: Fix CVV validation by resigning first responder (5.2/6)#2543robertdalmeida wants to merge 3 commits into
Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
ℹ️ No baseline data found for 'develop'.
|
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request enhances the security code input behavior in StoredCardInputViewController by managing focus states and implementing the FormTextItemViewDelegate. Key changes include automatically focusing the input field on load, resigning focus upon reaching the maximum character length, and adding integration tests for these behaviors. Feedback suggests improving encapsulation by avoiding direct access to the internal text field and enhancing the user experience by triggering the primary action when the return key is pressed.
✅ No changes detectedComparing Analyzed targets: Adyen, AdyenActions, AdyenCard, AdyenCardScanner, AdyenCashAppPay, AdyenCheckout, AdyenComponents, AdyenDelegatedAuthentication, AdyenDropIn, AdyenEncryption, AdyenSession, AdyenSwiftUI, AdyenTwint, AdyenUI, AdyenWeChatPay |
Summary [Required]
Fix bug 🐞 Validation issue with the FormCardSecurityItem - it accepts 4 digits even though UI accepts only 3.
Behaviour same as CardComponent - When the user enters the cvv code and reaches the max limit then it automatically resigns responder so the possibility of validation error is avoided.
Whats next?
Fix bug 🐞 Constraints issue with the FormCardSecurityCodeItemView.
Previous MR - #2506
Ticket [Optional]
COSDK-1140Checklist [Required]