v6 - Improve configuration builders#2755
Open
OscarSpruit wants to merge 3 commits into
Open
Conversation
The card extension function now directly accepts parameters. This makes it easier to discover what configuration options are available. Also, the fields are now alphabetically sorted, which should make it easier to find a specific field.
The threeDS2 extension function now directly accepts parameters. This makes it easier to discover what configuration options are available. Also, the fields are now alphabetically sorted, which should make it easier to find a specific field.
OscarSpruit
added
the
Chore
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the configuration API for the Card and 3DS2 components by removing the builder classes and replacing the lambda-based extension functions with versions that use optional parameters and @jvmoverloads. This change simplifies the configuration DSL and improves Java interoperability. I have no feedback to provide.
Contributor
✅ No public API changes |
|
araratthehero
previously approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR improves configuration builders by accepting direct parameters into the extension functions instead of using a lambda. This increases discoverability of the configuration options. Also, the fields are now alphabetically sorted, which makes it easier to find a specific field.