Suggestions gathered from Debian. #64
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thank you for your contribution. May I ask you to spin off into two separate PRs the following two commits: "Move PIC/shared options later on the command line for libraries" and "Fix and simplify build of static libraries" as those are relatively involved so we prefer to double-check them internally before approving. Thanks in advance. |
|
Hi. I have split the merge request. |
|
Hi. A rebase has been necessary because a recent commit on master was duplicated work. I have removed the related patch from the queue. |
|
I have moved each commit into its own merge request, hopefully reducing the work to rebase after the split of gprconfig_kb. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
I think that a github pull request is now the recommended way to suggest changes for gprbuild.
Each commit contains a separate suggestion. I may split the PRi if this fits your workflow better.
Thanks for considering.