ci: simplify ci workflow by using build-steps for old aswf containers, too #4932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, too Signed-off-by: Larry Gritz <[email protected]>
Collaborator
Author
|
This has been in review for over a week with no comments. Any objections? |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies the CI workflow by consolidating duplicate build logic. The aswf-old job now uses the reusable build-steps.yml workflow instead of duplicating all build steps inline, matching the pattern used in other jobs like aswf-new.
Key Changes:
- Refactored
aswf-oldjob to callbuild-steps.ymlinstead of inlining all steps - Added support for container volumes and old node installation in the reusable workflow
- Updated matrix configurations to use
optional_deps_appendparameter
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/ci.yml |
Replaced inline steps in aswf-old job with call to build-steps.yml; added optional_deps_append to matrix configurations |
.github/workflows/build-steps.yml |
Added container_volumes and old_node inputs to support requirements of old ASWF containers |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]> Signed-off-by: Larry Gritz <[email protected]>
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Oct 26, 2025
…, too (AcademySoftwareFoundation#4932) Trick learned from the rawtoaces CI workflow --------- Signed-off-by: Larry Gritz <[email protected]> Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trick learned from the rawtoaces CI workflow