build(gif): Add GIF library auto-build #4921
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Added build_GIF.cmake module for GIF library dependency management. Since GIFLIB does not provide a CMakeLists.txt, we created a custom one that gets added to the cloned repository. Since the flow is similar to other libraries with cmake support, I added a conditional statement in the build_dependency_with_cmake macro that, if a cmakelists.txt path is provided, will add/replace existing CMakeLists.txt files on the cloned repository. Signed-off-by: Valery Angelique <[email protected]>
lgritz
added
build / testing / port / CI
lgritz
approved these changes
Oct 6, 2025
Collaborator
lgritz
left a comment
lgritz
left a comment
There was a problem hiding this comment.
Holy cow, this is truly above and beyond the call of duty. When I wrote the issue, I don't think I realized that it lacked any cmake support, and I would not have expected (certainly not for a Dev Days level project) you to write a working CMake build system for another project.
Well done! This is great, thanks.
lgritz
changed the title
Collaborator
|
Great job, Valery! |
lgritz
pushed a commit
to lgritz/OpenImageIO
that referenced
this pull request
Oct 7, 2025
Fixes AcademySoftwareFoundation#4387 Added build_GIF.cmake module for GIF library dependency management. Since GIFLIB does not provide a CMakeLists.txt, I created a custom one that gets added to the cloned repository. The flow is similar to other libraries with cmake support, so I added a conditional statement in the build_dependency_with_cmake macro that, if a cmakelists.txt path is provided, will add/replace existing CMakeLists.txt files on the cloned repository. Signed-off-by: Valery Angelique <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4387
Added build_GIF.cmake module for GIF library dependency management. Since GIFLIB does not provide a CMakeLists.txt, I created a custom one that gets added to the cloned repository.
The flow is similar to other libraries with cmake support, so I added a conditional statement in the build_dependency_with_cmake macro that, if a cmakelists.txt path is provided, will add/replace existing CMakeLists.txt files on the cloned repository.
Tests
I checked that all jobs were successful on the CI. Small side note that some jobs, like
VFX2024 clang/C++17 py3.11 exr3.2 ocio2.3 / clang++ c++17 py3.11, already have GIFlib with the correct minimum version installed so the jobs pass without build_GIF being run.Checklist:
need to update the documentation, for example if this is a bug fix that
doesn't change the API.)
(adding new test cases if necessary).
corresponding Python bindings (and if altering ImageBufAlgo functions, also
exposed the new functionality as oiiotool options).
already run clang-format before submitting, I definitely will look at the CI
test that runs clang-format and fix anything that it highlights as being
nonconforming.