fix: sonar scan guard #4902
Merged
fix: sonar scan guard #4902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We recreated the SonarCloud project to clear the 404s. This commit fixes the workflow condition by comparing to the string '1', so the Sonar scan step runs and uploads results. Signed-off-by: Vanessa Valderrama <[email protected]>
lgritz
reviewed
Sep 24, 2025
Collaborator
lgritz
left a comment
lgritz
left a comment
There was a problem hiding this comment.
I'm not sure why this matters. In the analysis.yml, it's clearly passed as 1, not '1', so isn't an integer comparison going to be fine?
Collaborator
|
I'm not sure this is necessary. It's been like this for a long time, and the sonar step runs just fine when it's supposed to. (It was crashing in the sonar code itself! But it was not failing to run this step of the workflow.) |
lgritz
approved these changes
Sep 24, 2025
Collaborator
lgritz
left a comment
lgritz
left a comment
There was a problem hiding this comment.
LGTM, even though I don't think it's necessary, its probably correct?
lgritz
pushed a commit
to lgritz/OpenImageIO
that referenced
this pull request
Sep 27, 2025
We recreated the SonarCloud project to clear the 404s. This commit fixes the workflow condition by comparing to the string '1', so the Sonar scan step runs and uploads results. Updates the GHA workflow guard so the Sonar scan actually executes: - Change `if: inputs.sonar == 1` → `if: inputs.sonar == '1'` because `inputs.sonar` is a string (from `workflow_call` inputs). No unit tests added (CI-only change). Validation: run the “Analysis” workflow and confirm SonarCloud receives results. Signed-off-by: Vanessa Valderrama <[email protected]>
lgritz
added
the
build / testing / port / CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recreated the SonarCloud project to clear the 404s. This commit fixes the workflow condition by comparing to the string '1', so the Sonar scan step runs and uploads results.
Description
Updates the GHA workflow guard so the Sonar scan actually executes:
if: inputs.sonar == 1→if: inputs.sonar == '1'becauseinputs.sonaris a string (fromworkflow_callinputs).Tests
No unit tests added (CI-only change). Validation: run the “Analysis” workflow and confirm SonarCloud receives results.
Checklist: