ci: disable macos-x86 wheels. #4886
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
Temporary workaround to unblock publishing of other wheels for 3.1 release Signed-off-by: Zach Lewis <[email protected]>
zachlewis
force-pushed
the
wheels_disable_macos_x86
branch
from
51c36ed to
f96f7d7
Compare
lgritz
reviewed
Sep 15, 2025
Comment on lines
+233
to
+235
| # if: | | ||
| # github.event_name != 'schedule' || | ||
| # github.repository == 'AcademySoftwareFoundation/OpenImageIO' |
Collaborator
There was a problem hiding this comment.
Just as an FYI, I think you could just change this to
Suggested change
| # if: | | |
| # github.event_name != 'schedule' || | |
| # github.repository == 'AcademySoftwareFoundation/OpenImageIO' | |
| if: | | |
| 0 && (github.event_name != 'schedule' || | |
| github.repository == 'AcademySoftwareFoundation/OpenImageIO)' |
and not need to comment out the whole thing. Or even only do it if the branch name is something special, so it would only run for you while you're continuing to test, but not for anyone else.
Collaborator
Author
There was a problem hiding this comment.
ooohhh, smart...
Unless you feel otherwise, I think I'd rather leave it as-is, just to make it super apparent what was changed, and that I intend to change it back; but I'm happy to do whatever you feel is best.
Collaborator
There was a problem hiding this comment.
No problem, I will merge as-is.
Collaborator
Author
There was a problem hiding this comment.
thanks for showing me this, btw -- I've been using this trick to quickly "solo" the macos-x86 wheels tasks to help me debug #4855
lgritz
pushed a commit
to lgritz/OpenImageIO
that referenced
this pull request
Sep 16, 2025
Temporary workaround to unblock publishing of other wheels for 3.1 release Signed-off-by: Zach Lewis <[email protected]>
zachlewis
added a commit
to zachlewis/OpenImageIO
that referenced
this pull request
Sep 16, 2025
Temporary workaround to unblock publishing of other wheels for 3.1 release Signed-off-by: Zach Lewis <[email protected]>
lgritz
pushed a commit
to lgritz/OpenImageIO
that referenced
this pull request
Sep 16, 2025
Temporary workaround to unblock publishing of other wheels for 3.1 release Signed-off-by: Zach Lewis <[email protected]>
lgritz
pushed a commit
to lgritz/OpenImageIO
that referenced
this pull request
Sep 16, 2025
Temporary workaround to unblock publishing of other wheels for 3.1 release Signed-off-by: Zach Lewis <[email protected]>
lgritz
pushed a commit
to lgritz/OpenImageIO
that referenced
this pull request
Sep 17, 2025
Temporary workaround to unblock publishing of other wheels for 3.1 release Signed-off-by: Zach Lewis <[email protected]>
lgritz
added
the
build / testing / port / CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporary workaround to unblock publishing of other wheels for 3.1 release