Skip to content

Conversation

@lgritz
Copy link
Collaborator

@lgritz lgritz commented Jul 30, 2025

  • Allow CMAKE_MSVC_RUNTIME_LIBRARY to be initialized from an environment variable of the same name. (CMake doesn't do that on its own.)

  • If set, propagate CMAKE_MSVC_RUNTIME_LIBRARY to any packages we auto-build within our build system.

* Allow CMAKE_MSVC_RUNTIME_LIBRARY to be initialized from an environment
  variable of the same name. (CMake doesn't do that on its own.)

* If set, propagate CMAKE_MSVC_RUNTIME_LIBRARY to any packages we
  auto-build within our build system.

Signed-off-by: Larry Gritz <[email protected]>
@lgritz lgritz requested a review from fpsunflower July 30, 2025 19:15
@lgritz lgritz added the build / testing / port / CI Affecting the build system, tests, platform support, porting, or continuous integration. label Jul 30, 2025
@lgritz
Copy link
Collaborator Author

lgritz commented Jul 31, 2025

Anybody with Windows experience want to give an approve? I need this in place to fix something on the OSL side.

@lgritz
Copy link
Collaborator Author

lgritz commented Jul 31, 2025

I got a LGTM offline from somebody who tried it and confirmed the fix, but isn't allowed to comment publicly. So merging.

Edit: oh crap, I posted this in the wrong ticket. Never mind.

@lgritz
Copy link
Collaborator Author

lgritz commented Jul 31, 2025

I'm going to merge this by the end of the day if there are no objections, so that it can be incorporated into the release tomorrow.

@lgritz lgritz merged commit 4bba40d into AcademySoftwareFoundation:main Aug 1, 2025
68 checks passed
lgritz added a commit to lgritz/OpenImageIO that referenced this pull request Aug 1, 2025
…n#4842)

* Allow CMAKE_MSVC_RUNTIME_LIBRARY to be initialized from an environment
variable of the same name. (CMake doesn't do that on its own.)

* If set, propagate CMAKE_MSVC_RUNTIME_LIBRARY to any packages we
auto-build within our build system.

Signed-off-by: Larry Gritz <[email protected]>
@lgritz lgritz deleted the lg-windowsstatic branch August 1, 2025 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build / testing / port / CI Affecting the build system, tests, platform support, porting, or continuous integration.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant