fix: build break from untested combo of two PRs #4794
Conversation
Oops, my bad. Looks like AcademySoftwareFoundation#4664 (merged about a week ago) and AcademySoftwareFoundation#4783 (merged today, but authored before AcademySoftwareFoundation#4664 was merged) interacted in a way that produced a build break. This tiny fix is essential to unbreak it. Signed-off-by: Larry Gritz <[email protected]>
|
Need to fast track this emergency fix. If CI fully passes, I will merge it preemptively. So sorry, same-day merges, especially those without a review, should be vanishingly rare. But this is an embarrassingly serious build break that has a one-line fix. |
ThiagoIze
left a comment
ThiagoIze
left a comment
There was a problem hiding this comment.
adding in the requested miplevel seems pretty simple/safe to me.
|
Not adding, subtracting -- the (private) call changed in one of the PRs to remove an unneeded argument (and the other PR added a call to the one with the old signature). We decided that each MIP level didn't need a separately allocated ImageSpec because there's no format we support that allows arbitrary metadata to be set PER MIPLEVEL. Resolution, etc. is the only thing that changes from miplevel to miplevel within one subimage. |
|
oh indeed. I got the two sides confused. |
lgritz
added
the
build / testing / port / CI
…ation#4794) Oops, my bad. Looks like AcademySoftwareFoundation#4664 (merged about a week ago) and AcademySoftwareFoundation#4783 (merged today, but authored before AcademySoftwareFoundation#4664 was merged) interacted in a way that produced a build break. This tiny fix is essential to unbreak it. Signed-off-by: Larry Gritz <[email protected]>
…ation#4794) Oops, my bad. Looks like AcademySoftwareFoundation#4664 (merged about a week ago) and AcademySoftwareFoundation#4783 (merged today, but authored before AcademySoftwareFoundation#4664 was merged) interacted in a way that produced a build break. This tiny fix is essential to unbreak it. Signed-off-by: Larry Gritz <[email protected]>
2 participants
Oops, my bad. Looks like #4664 (merged about a week ago) and #4783 (merged today, but authored before #4664 was merged) interacted in a way that produced a build break. This tiny fix is essential to unbreak it.