CI pkg config libdir fix #4775
CI pkg config libdir fix #4775
Conversation
scott-wilson
force-pushed
the
ci_pkgconfig_build_fix
branch
from
4b89ab4 to
0e49b00
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| time sudo yum install -y ${EXTRA_DEP_PACKAGES} || true | ||
| fi | ||
| if [[ "${PIP_INSTALLS}" != "" ]] ; then | ||
| time pip3 install ${PIP_INSTALLS} || true |
Check warning
Code scanning / Scorecard
Pinned-Dependencies
| if [[ "${USE_PYTHON}" != "0" ]] ; then | ||
| time sudo apt-get -q install -y python3-numpy | ||
| fi | ||
| if [[ "${PIP_INSTALLS}" != "" ]] ; then |
Check warning
Code scanning / Scorecard
Pinned-Dependencies
|
Ack, sorry for the extra noise. I have a commit from 2015 that wasn't DSO signed. I followed the recommendations and now there's almost 500 commits for a single change. 🙃 |
lgritz
left a comment
lgritz
left a comment
There was a problem hiding this comment.
LGTM
merge history aside, this is a one-line fix and it will all be squashed and rebased as part of the merge
|
How did you even do this? It's not letting me merge because of the DCO check. I don't understand how you got into this state. Can you try this:
|
scott-wilson
force-pushed
the
ci_pkgconfig_build_fix
branch
from
46091e4 to
09f2881
Compare
|
Sorry about that, for some reason my Git-fu failed me. Commit recreated and pushed. |
…absolute path Signed-off-by: Scott Wilson <[email protected]>
lgritz
force-pushed
the
ci_pkgconfig_build_fix
branch
from
09f2881 to
4a72248
Compare
|
I was able to fix it up and push back to your tree. |
This was causing the Rust bindings to fail because the pkgconfig was pointing to a path that didn't exist (the libdir was the full root appended to itself). Signed-off-by: Scott Wilson <[email protected]>
lgritz
added
the
build / testing / port / CI
This was causing the Rust bindings to fail because the pkgconfig was pointing to a path that didn't exist (the libdir was the full root appended to itself). Signed-off-by: Scott Wilson <[email protected]>
2 participants
Description
This was causing the Rust bindings to fail because the pkgconfig was pointing to a path that didn't exist (the libdir was the full root appended to itself).
Tests
This should not make the CI fail, but will affect the Rust build.
Checklist:
need to update the documentation, for example if this is a bug fix that
doesn't change the API.)
(adding new test cases if necessary).
corresponding Python bindings (and if altering ImageBufAlgo functions, also
exposed the new functionality as oiiotool options).
already run clang-format before submitting, I definitely will look at the CI
test that runs clang-format and fix anything that it highlights as being
nonconforming.