Skip to content

Conversation

@soswow
Copy link
Contributor

@soswow soswow commented May 18, 2025

Description

Master version of the iv today when opening on mac sometimes opens without a focus, which causes top menu bar not to be populated (just iv on the left). Workaround is to switch back and forth once to and from another app for menu bar too get populated.

It is unclear to me how reliably replicate the bug so that I have a solid prove, that this fix works. But since building with this line it never happend to me yet.

Maybe more knowledgable in Qt can verify if it makes sense.

Checklist:

  • I have read the contribution guidelines.
  • I have updated the documentation, if applicable. (Check if there is no
    need to update the documentation, for example if this is a bug fix that
    doesn't change the API.)
  • I have ensured that the change is tested somewhere in the testsuite
    (adding new test cases if necessary).
  • If I added or modified a C++ API call, I have also amended the
    corresponding Python bindings (and if altering ImageBufAlgo functions, also
    exposed the new functionality as oiiotool options).
  • My code follows the prevailing code style of this project. If I haven't
    already run clang-format before submitting, I definitely will look at the CI
    test that runs clang-format and fix anything that it highlights as being
    nonconforming.

@soswow soswow force-pushed the fix-bug-with-window-loosing-focus-on-mac-on-startup branch from 09a0629 to 2416186 Compare May 18, 2025 08:52
@lgritz
Copy link
Collaborator

lgritz commented May 18, 2025

Thanks. I encounter this bug, too, but had no idea how to fix. I will test on my end.

Copy link
Collaborator

@lgritz lgritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I don't understand how or why this works, but I can totally confirm that it fixes the problem for me. I'd been encountering this for a while, but assumed it was some interaction between my still being on an old version of MacOS, and whatever version of Qt I had, or some other combination specific to me. I never would have known how to fix it entirely on our end with just one more Qt call. Thanks for fixing!!

@lgritz lgritz changed the title Bug fix proposal for window loosing focus on mac on startup fix(iv): Bug fix for iv window loosing focus on mac on startup May 19, 2025
@lgritz lgritz merged commit 6cb8714 into AcademySoftwareFoundation:main May 19, 2025
29 checks passed
lgritz pushed a commit to lgritz/OpenImageIO that referenced this pull request May 19, 2025
…mySoftwareFoundation#4773)

Master version of the iv today when opening on mac sometimes opens
without a focus, which causes top menu bar not to be populated (just
`iv` on the left). Workaround is to switch back and forth once to and
from another app for menu bar too get populated.

It is unclear to me how reliably replicate the bug so that I have a
solid prove, that this fix works. But since building with this line it
never happened to me yet.

Maybe more knowledgeable in Qt can verify if it makes sense.

Signed-off-by: Aleksandr Motsjonov <[email protected]>
@lgritz lgritz added the iv Image viewer label Jul 13, 2025
zachlewis pushed a commit to zachlewis/OpenImageIO that referenced this pull request Aug 1, 2025
…mySoftwareFoundation#4773)

Master version of the iv today when opening on mac sometimes opens
without a focus, which causes top menu bar not to be populated (just
`iv` on the left). Workaround is to switch back and forth once to and
from another app for menu bar too get populated.

It is unclear to me how reliably replicate the bug so that I have a
solid prove, that this fix works. But since building with this line it
never happened to me yet.

Maybe more knowledgeable in Qt can verify if it makes sense.

Signed-off-by: Aleksandr Motsjonov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

iv Image viewer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants