build: fix failed test with old fmt #4758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our fmath_test (a.k.a. unit_fmath) test was failing with an exception thrown by the fmt library because we used a width specifier when formatting a TypeDesc. It was really only an issue when using old fmt < 10.0, so I'm just solving it trivially by ignoring that specifier for old fmt. It doesn't seem necessary to make it work correctly with width specifiers for old versions, when we don't in any way rely on it. Signed-off-by: Larry Gritz <[email protected]>
lgritz
added
bug
Collaborator
Author
|
Pre-emptively merging because this fixes an important test breakage for some people using old versions of fmtlib. (But can't possibly break anybody using more recent versions, since the changes are entirely inside an |
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
May 17, 2025
Our fmath_test (a.k.a. unit_fmath) test was failing with an exception thrown by the fmt library because we used a width specifier when formatting a TypeDesc. It was really only an issue when using old fmt < 10.0, so I'm just solving it trivially by ignoring that specifier for old fmt. It doesn't seem necessary to make it work correctly with width specifiers for old versions, when we don't in any way rely on it. Signed-off-by: Larry Gritz <[email protected]>
scott-wilson
pushed a commit
to scott-wilson/OpenImageIO
that referenced
this pull request
May 18, 2025
Our fmath_test (a.k.a. unit_fmath) test was failing with an exception thrown by the fmt library because we used a width specifier when formatting a TypeDesc. It was really only an issue when using old fmt < 10.0, so I'm just solving it trivially by ignoring that specifier for old fmt. It doesn't seem necessary to make it work correctly with width specifiers for old versions, when we don't in any way rely on it. Signed-off-by: Larry Gritz <[email protected]> Signed-off-by: Scott Wilson <[email protected]>
zachlewis
pushed a commit
to zachlewis/OpenImageIO
that referenced
this pull request
Aug 1, 2025
Our fmath_test (a.k.a. unit_fmath) test was failing with an exception thrown by the fmt library because we used a width specifier when formatting a TypeDesc. It was really only an issue when using old fmt < 10.0, so I'm just solving it trivially by ignoring that specifier for old fmt. It doesn't seem necessary to make it work correctly with width specifiers for old versions, when we don't in any way rely on it. Signed-off-by: Larry Gritz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our fmath_test (a.k.a. unit_fmath) test was failing with an exception thrown by the fmt library because we used a width specifier when formatting a TypeDesc.
It was really only an issue when using old fmt < 10.0, so I'm just solving it trivially by ignoring that specifier for old fmt. It doesn't seem necessary to make it work correctly with width specifiers for old versions, when we don't in any way rely on it.