fix(exr): not honoring 'missingcolor' for scanline files #4757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgritz
added
bug
As a reminder, the global OIIO attribute "missingcolor", or the file-specific ImageInput open hint "oiio:missingcolor" is designed to treat missing scanlines or tiles as not a true error, but instead just pass over them and substitute the missingcolor value for those missing areas on the file. The nature of this PR is that while we had implemented this behavior fully for tile-based exr files, we never did so for scanline-based files. So here we do. Now then, unfortunately, it does not work. I think it's a bug in the OpenEXR library itself, but we're still trying to figure that out. But nonetheless, I believe this change is correct. Signed-off-by: Larry Gritz <[email protected]>
Collaborator
Author
|
No objections for two weeks -> merging |
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Jun 5, 2025
…wareFoundation#4757) As a reminder, the global OIIO attribute "missingcolor", or the file-specific ImageInput open hint "oiio:missingcolor" is designed to treat missing scanlines or tiles as not a true error, but instead just pass over them and substitute the missingcolor value for those missing areas on the file. The nature of this PR is that while we had implemented this behavior fully for tile-based exr files, we never did so for scanline-based files. So here we do. Now then, unfortunately, it does not work. I think it's a bug in the OpenEXR library itself, but we're still trying to figure that out. But nonetheless, I believe this change is correct. Signed-off-by: Larry Gritz <[email protected]>
zachlewis
pushed a commit
to zachlewis/OpenImageIO
that referenced
this pull request
Aug 1, 2025
…wareFoundation#4757) As a reminder, the global OIIO attribute "missingcolor", or the file-specific ImageInput open hint "oiio:missingcolor" is designed to treat missing scanlines or tiles as not a true error, but instead just pass over them and substitute the missingcolor value for those missing areas on the file. The nature of this PR is that while we had implemented this behavior fully for tile-based exr files, we never did so for scanline-based files. So here we do. Now then, unfortunately, it does not work. I think it's a bug in the OpenEXR library itself, but we're still trying to figure that out. But nonetheless, I believe this change is correct. Signed-off-by: Larry Gritz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a reminder, the global OIIO attribute "missingcolor", or the file-specific ImageInput open hint "oiio:missingcolor" is designed to treat missing scanlines or tiles as not a true error, but instead just pass over them and substitute the missingcolor value for those missing areas on the file.
The nature of this PR is that while we had implemented this behavior fully for tile-based exr files, we never did so for scanline-based files. So here we do.
Now then, unfortunately, it does not work. I think it's a bug in the OpenEXR library itself, but we're still trying to figure that out. But nonetheless, I believe this change is correct.