fix: ImageInput/ImageOutput did not set per-file threads correctly #4750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
II and IO were documented as initializing their internal "how many
threads to use when reading/writing this particular file" to the
global "threads" OIIO attribute. But they did not, they always
initialized to 0 ("all the threads") even if the global attribute had
been set differently prior to creation of the reader or writer.
Signed-off-by: Larry Gritz <[email protected]>
Signed-off-by: Larry Gritz <[email protected]>
lgritz
added
bug
Collaborator
Author
|
Any objections here? |
Contributor
|
None, lgtm |
EmilDohne
approved these changes
May 17, 2025
scott-wilson
pushed a commit
to scott-wilson/OpenImageIO
that referenced
this pull request
May 18, 2025
…cademySoftwareFoundation#4750) II and IO were documented as initializing their internal "how many threads to use when reading/writing this particular file" to the global "threads" OIIO attribute. But they did not, they always initialized to 0 ("all the threads") even if the global attribute had been set differently prior to creation of the reader or writer. --------- Signed-off-by: Larry Gritz <[email protected]> Signed-off-by: Scott Wilson <[email protected]>
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
May 19, 2025
…cademySoftwareFoundation#4750) II and IO were documented as initializing their internal "how many threads to use when reading/writing this particular file" to the global "threads" OIIO attribute. But they did not, they always initialized to 0 ("all the threads") even if the global attribute had been set differently prior to creation of the reader or writer. --------- Signed-off-by: Larry Gritz <[email protected]>
zachlewis
pushed a commit
to zachlewis/OpenImageIO
that referenced
this pull request
Aug 1, 2025
…cademySoftwareFoundation#4750) II and IO were documented as initializing their internal "how many threads to use when reading/writing this particular file" to the global "threads" OIIO attribute. But they did not, they always initialized to 0 ("all the threads") even if the global attribute had been set differently prior to creation of the reader or writer. --------- Signed-off-by: Larry Gritz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
II and IO were documented as initializing their internal "how many threads to use when reading/writing this particular file" to the global "threads" OIIO attribute. But they did not, they always initialized to 0 ("all the threads") even if the global attribute had been set differently prior to creation of the reader or writer.