build: Restore OIIO_AVX512ER_ENABLED preprocessor symbol #4735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This useless symbol was removed in PR 4724, but maybe downstream things used it and will break simply because it was removed, even though it never would have been nonzero. Signed-off-by: Larry Gritz <[email protected]>
Collaborator
Author
|
Merging PRs without review and without leaving at least several days for reviews to occur is considered bad in all but the most pressing cases, but I'm going to do it in this case because it's repairing an unintentional compatibility break that affects downstream projects and is in fact breaking OSL CI and holding up a release. If somebody has an objection after the fact, please speak up and we will amend. |
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
May 3, 2025
…wareFoundation#4735) This useless symbol was removed in PR AcademySoftwareFoundation#4724, but maybe downstream things used it and will break simply because it was removed, even though it never would have been nonzero. It should not have been completely removed except at a compatibility-breaking version boundary. Signed-off-by: Larry Gritz <[email protected]>
scott-wilson
pushed a commit
to scott-wilson/OpenImageIO
that referenced
this pull request
May 17, 2025
…wareFoundation#4735) This useless symbol was removed in PR AcademySoftwareFoundation#4724, but maybe downstream things used it and will break simply because it was removed, even though it never would have been nonzero. It should not have been completely removed except at a compatibility-breaking version boundary. Signed-off-by: Larry Gritz <[email protected]> Signed-off-by: Scott Wilson <[email protected]>
scott-wilson
pushed a commit
to scott-wilson/OpenImageIO
that referenced
this pull request
May 18, 2025
…wareFoundation#4735) This useless symbol was removed in PR AcademySoftwareFoundation#4724, but maybe downstream things used it and will break simply because it was removed, even though it never would have been nonzero. It should not have been completely removed except at a compatibility-breaking version boundary. Signed-off-by: Larry Gritz <[email protected]> Signed-off-by: Scott Wilson <[email protected]>
lgritz
added
the
build / testing / port / CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This useless symbol was removed in PR #4724, but maybe downstream things used it and will break simply because it was removed, even though it never would have been nonzero. It should not have been completely removed except at a compatibility-breaking version boundary.