fix(exr): fill in OpenEXR lineOrder attribute when reading

[vernalchen]

Description

Fill in OpenEXR lineOrder attribute when parsing the header in OpenEXRCoreInput::PartInfo::parse_header()

Tests

Checklist:

• I have read the contribution guidelines.
• I have updated the documentation, if applicable. (Check if there is no
  need to update the documentation, for example if this is a bug fix that
  doesn't change the API.)
• I have ensured that the change is tested somewhere in the testsuite
  (adding new test cases if necessary).
• If I added or modified a C++ API call, I have also amended the
  corresponding Python bindings (and if altering ImageBufAlgo functions, also
  exposed the new functionality as oiiotool options).
• My code follows the prevailing code style of this project. If I haven't
  already run clang-format before submitting, I definitely will look at the CI
  test that runs clang-format and fix anything that it highlights as being
  nonconforming.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: lgritz / name: Larry Gritz (9fb5ca8)
• ✅ login: vernalchen (035afd5, 2c5b23f, eb93431)

[lgritz]

I think you'll need to make the equivalent change in exrinput.cpp.

Also, in both of those files, there's a line that purports to ignore such lines (just search for "lineorder" and you'll see it), which should probably be removed.

[vernalchen]

Remove ignore line for lineOrder

[lgritz]

Code LGTM, now you just need to fix all the tests so CI passes.

[lgritz]

I think the clang-format test caught some nonstandard formatting. Is this easily fixable on your end? If not, I can do it from my end as well.

[vernalchen]

I think the clang-format test caught some nonstandard formatting. Is this easily fixable on your end? If not, I can do it from my end as well.

It will be very helpful if you could help fix test failures.

[lgritz]

Hi, I'll take care of the test failures. Also, I'm not sure why you changed the name from "openexr:lineOrder" to "lineOrder", but it should have been the first way.

I'm in the middle of this now, please don't update until after I've done so.

[vernalchen]

Hi, I'll take care of the test failures. Also, I'm not sure why you changed the name from "openexr:lineOrder" to "lineOrder", but it should have been the first way.

I'm in the middle of this now, please don't update until after I've done so.

HI, I have problems running tests locally, so I did the change according to the CI logs, such as below.

comparing out.txt to ref/out.txt
Diff out.txt vs ref/out.txt was:
-------
--- out.txt	Sat Feb  8 01:15:48 2025
+++ ref/out.txt	Sat Feb  8 01:06:08 2025
@@ -142,7 +142,6 @@
 src/tiny-az.exr :     full/display origin: 1, 1
 src/tiny-az.exr :     compression: "zip"
 src/tiny-az.exr :     DateTime: "2022:11:23 15:17:24"
-src/tiny-az.exr :     lineOrder: "increasingY"
 src/tiny-az.exr :     PixelAspectRatio: 1
 src/tiny-az.exr :     screenWindowCenter: 0, 0
 src/tiny-az.exr :     screenWindowWidth: 1
@@ -150,6 +149,7 @@
 src/tiny-az.exr :     Exif:ImageHistory: "oiiotool -pattern constant:color=0.25,0.5,0.75 4x4 3 --origin +2+2 --fullsize 20x20+1+1 -o tiny-az.exr"
 src/tiny-az.exr :     oiio:ColorSpace: "lin_rec709"
 src/tiny-az.exr :     oiio:subimages: 1
+src/tiny-az.exr :     openexr:lineOrder: "increasingY"
 src/tiny-az.exr :     Stats Min: 0.250000 0.500000 0.750000 (float)
     Stats Max: 0.250000 0.500000 0.750000 (float)
     Stats Avg: 0.250000 0.500000 0.750000 (float)

It's glad to hear that you are helping with the test failures, thanks so much!

[lgritz]

I fixed up the test output and attribute name. All CI seems to pass now, LGTM!