Skip to content

Conversation

@antond-weta
Copy link
Contributor

Description

Adds attributes to the output ImageBuf for the black level and bit depth when the raw bayer buffer is requested.

Tests

I believe we don't test the retrieved metadata currently. We may want to start doing that eventually?

Checklist:

  • I have read the contribution guidelines.
  • I have updated the documentation, if applicable. (Check if there is no
    need to update the documentation, for example if this is a bug fix that
    doesn't change the API.)
  • I have ensured that the change is tested somewhere in the testsuite
    (adding new test cases if necessary).
  • If I added or modified a C++ API call, I have also amended the
    corresponding Python bindings (and if altering ImageBufAlgo functions, also
    exposed the new functionality as oiiotool options).
  • My code follows the prevailing code style of this project. If I haven't
    already run clang-format before submitting, I definitely will look at the CI
    test that runs clang-format and fix anything that it highlights as being
    nonconforming.

Copy link
Collaborator

@lgritz lgritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lgritz lgritz merged commit 4bf3012 into AcademySoftwareFoundation:main Jan 21, 2025
27 checks passed
lgritz pushed a commit to lgritz/OpenImageIO that referenced this pull request Jan 21, 2025
…n#4601)

Adds attributes to the input's ImageSpec for the black level and bit depth
when the raw bayer buffer is requested.

Signed-off-by: Anton Dukhovnikov <[email protected]>
scott-wilson pushed a commit to scott-wilson/OpenImageIO that referenced this pull request May 18, 2025
…n#4601)

Adds attributes to the input's ImageSpec for the black level and bit depth
when the raw bayer buffer is requested.

Signed-off-by: Anton Dukhovnikov <[email protected]>
Signed-off-by: Scott Wilson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants