testing: better testing coverage of null image reader/writer #4578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves the medicre testing line coverage in nullimageio.cpp from 50% to 95%. * Test writing * Test reading of tiled and MIP-mapped null images * Test setting and reading of attributes * Along the way, identified and fixed a nullimage bug -- it was answering that it supported "rectangles" but had no write_rectangle method. Testing works! Signed-off-by: Larry Gritz <[email protected]>
Collaborator
Author
|
Seem ok? |
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Jan 8, 2025
…SoftwareFoundation#4578) This improves the mediocre testing line coverage in nullimageio.cpp from 50% to 95%. * Test writing * Test reading of tiled and MIP-mapped null images * Test setting and reading of attributes * Simplify some code * Along the way, identified and fixed a nullimage bug -- it was answering that it supported "rectangles" but had no write_rectangle method. Testing works! Signed-off-by: Larry Gritz <[email protected]>
scott-wilson
pushed a commit
to scott-wilson/OpenImageIO
that referenced
this pull request
May 18, 2025
…SoftwareFoundation#4578) This improves the mediocre testing line coverage in nullimageio.cpp from 50% to 95%. * Test writing * Test reading of tiled and MIP-mapped null images * Test setting and reading of attributes * Simplify some code * Along the way, identified and fixed a nullimage bug -- it was answering that it supported "rectangles" but had no write_rectangle method. Testing works! Signed-off-by: Larry Gritz <[email protected]> Signed-off-by: Scott Wilson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the mediocre testing line coverage in nullimageio.cpp from 50% to 95%.