-
Notifications
You must be signed in to change notification settings - Fork 472
Bugfix/1868 #2163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Bugfix/1868 #2163
Conversation
Signed-off-by: avisd <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Drew Avis!
Here are a few suggestions to improve things further.
@@ -27,6 +27,27 @@ For verbose test output (listing each test and result status), run:: | |||
|
|||
ctest -V | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The word "should" appears twice on line 22, please correct that too.
|
||
Similarly you can run just Python tests directly:: | ||
|
||
python3 tests/python/OpenColorIOTestSuite.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove lines 47-50, it is better to just run those via ctest as described on line 40.
run only the CPU unit tests from the Builtins suite:: | ||
|
||
tests/cpu/test_cpu_exec --run_only Builtins | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the following:
Additional options for the CPU tests, such as --stop_on_error
are described using the --help
option:
tests/cpu/test_cpu_exec --help
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, Drew!
@drewavisautodesk , you need to sign your commits for the DCO check to pass. Usually one may do: |
Adding additional information about running named tests to the "Unit Tests" section of the Contributing Guide. This is for Issue #1868 - "Improve Documentation for running unit tests".