Allow hardware specific region-ACL extensions #320
Conversation
| vmpu_mpu_set_static_acl(1, FLASH_ORIGIN, (uint32_t) __uvisor_config.secure_end - FLASH_ORIGIN, | ||
| UVISOR_TACL_SREAD | | ||
| UVISOR_TACL_SEXECUTE | | ||
| UVISOR_TACL_UREAD | | ||
| UVISOR_TACL_UEXECUTE | | ||
| UVISOR_TACL_USER); | ||
| UVISOR_TACL_USER, | ||
| 0x4UL<<18); |
There was a problem hiding this comment.
Could you add spaces in 0x4UL << 18)? (also in the other occurrence below)
BTW, do we want to provide an interface/macro for selecting a certain bus master or to set the K64F-specific ACLs? The hardcoded numbers are not very user-friendly. If we don't want to do it now we can add and issue/story.
|
@AlessandroA I fixed the spacing problem. I would like to avoid though macros for now for the hw-specific ACLs, as they are currently only used in this two lines plus I don't want to make this "as thing". |
| /* Allow uVisor-internal code to extend permissions for certain | ||
| * ACLs by hardware-specific ACLs like DMA busmaster access. | ||
| * Ensure that core ACLs are specified trough the generic ACL | ||
| * method b masking it out. */ |
There was a problem hiding this comment.
- * method b masking it out. */
+ * method by masking it out. */Move subregion configuration into HW-specific ACLs: - For K64F DMA Busmaster overrides are possible - For ARMv7-M Subregions can be defined
|
LGTM 👍 |
|
DMA confirmed to work (see #315) to/from box 0 using LwIP as a test case (the original motivation for this patch). Other problems related to managing mutually exclusive memory (mutex) at run-time have now manifested as either a side-effect of this patch or as something previously unknown and un-tested. See the above quoted git issue for more information. |
@AlessandroA