configure: Add --profile for profile selection #293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LDong-Arm
force-pushed
the
configure_profile
branch
from
5d311d9 to
71eea10
Compare
|
I first made the fix locally while working on #292 ( |
Codecov Report
@@ Coverage Diff @@
## master #293 +/- ##
=======================================
Coverage 97.08% 97.08%
=======================================
Files 92 92
Lines 2781 2782 +1
=======================================
+ Hits 2700 2701 +1
Misses 81 81
|
|
@ARMmbed/mbed-os-core |
|
Travis timed out. Could you force push to trigger it again? |
LDong-Arm
force-pushed
the
configure_profile
branch
from
71eea10 to
e1355e2
Compare
Done. Waiting for CI to finish. |
rwalton-arm
reviewed
Jul 1, 2021
| @@ -186,6 +186,29 @@ def test_app_config_used_when_passed( | |||
| generate_config.assert_called_once_with(target.upper(), toolchain.upper(), program) | |||
| self.assertEqual(program.files.app_config_file, app_config_path) | |||
|
|
|||
| def test_profile_used_when_passed( | |||
The `compile` subcommand supports `--profile` to specify build profile, but a test for it is missing. This commit adds a test.
As `mbed-tools compile` supports `-b`, `--profile` for selecting a build profile, the same should exist for `mbed-tools configure` as users may want to manually run the build step using `cmake` in some cases. This commit implements it and supplies a test. Note: This only affects the build directory - it has no impact on the contents of `mbed_config.cmake`. To actually build an application with a profile, a user needs to either run `mbed-tools compile` with `--profile <profile>`, or manually run `cmake` with `-DCMAKE_BUILD_TYPE=<profile>` after `mbed-tools configure`. Fixes ARMmbed#262
LDong-Arm
force-pushed
the
configure_profile
branch
from
e1355e2 to
923b263
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As
mbed-tools compilesupports-b,--profilefor selecting a build profile, the same should exist formbed-tools configureas users may want to manually run the build step usingcmakein some cases. This PR implements it and supplies a test.Note: This only affects the build directory - it has no impact on the contents of
mbed_config.cmake. To actually build an application with a profile, a user needs to either runmbed-tools compilewith--profile <profile>, or manually runcmakewith-DCMAKE_BUILD_TYPE=<profile>aftermbed-tools configure.Also add missing test for
--profileofmbed-tools compile.Fixes #262
Test Coverage