M2351: Fix crypto AC management #9656
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Port of NUC472/M487 crypto AC mgmt work to M2351: 1. Choose mutex to synchronize access to crypto non-SHA AC 2. Choose atomic flag to synchronize access to crypto SHA AC
kjbracey
approved these changes
Feb 11, 2019
| @@ -19,33 +19,51 @@ | |||
| #include "mbed_assert.h" | |||
| #include "mbed_critical.h" | |||
| #include "mbed_error.h" | |||
| #if MBED_CONF_RTOS_PRESENT | |||
| #include "cmsis_os2.h" | |||
There was a problem hiding this comment.
Is this really needed? You're not using it directly, but maybe something's missing from another header?
There was a problem hiding this comment.
@kjbracey-arm I removed them.
| #if MBED_CONF_RTOS_PRESENT | ||
| #include "cmsis_os2.h" | ||
| #endif | ||
| #include <string.h> |
There was a problem hiding this comment.
Ditto - you're not adding anything using it that I can see.
kjbracey
approved these changes
Feb 11, 2019
0xc0170
approved these changes
Feb 11, 2019
|
CI started |
Test run: SUCCESSSummary: 12 of 12 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR ports #9081 work to NUMAKER_PFM_M2351 target. It majorly includes:
Pull request type
Reviewers
@kjbracey-arm