Skip to content

ESP8266: Set HW reset time to 2ms #9290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2019

Conversation

SeppoTakalo
Copy link
Contributor

Description

Documentation says 200 us should have been enough, but experimentation shows that 1 ms was not enough, but 2 ms is.

Maybe there is RC effect on the shield I'm using.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@VeijoPesonen

@ciarmcom ciarmcom requested review from VeijoPesonen and a team January 8, 2019 18:00
@ciarmcom
Copy link
Member

ciarmcom commented Jan 8, 2019

@SeppoTakalo, thank you for your changes.
@VeijoPesonen @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

@SeppoTakalo
Copy link
Contributor Author

@0xc0170 or @adbridge Can you guys speed this up. This is a small fix but quite important.

@SeppoTakalo
Copy link
Contributor Author

This is a must for 5.11.2
(For Client tests)

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 9, 2019

CI started

@alekla01
Copy link
Contributor

alekla01 commented Jan 9, 2019

CI restarted

@mbed-ci
Copy link

mbed-ci commented Jan 9, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@SeppoTakalo
Copy link
Contributor Author

What was the failure?

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 9, 2019

@alekla01 Can you help ? I can't find the log. I found 2 earlier failed in the early phase, but not hte last one (3rd run is green, but here we can see still pending). The log published above does not have any failures but I can see the second test there has only one target

@cmonr cmonr merged commit cd03eaf into ARMmbed:master Jan 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants