ESP8266: Fixes AT-layer socket_open-functions #9284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@VeijoPesonen, thank you for your changes. |
SeppoTakalo
approved these changes
Jan 8, 2019
0xc0170
changed the title
0xc0170
approved these changes
Jan 8, 2019
|
Can you rebase? We fixed Travis failures on master hours ago, and this change should be propagated here via rebase. We will start CI right after travis fix. I can rebase this later today if not yet done. |
When a socket open fails it musn't be treated as fatal error. Returning a device error which is then handled by an application is the correct solution
|
@0xc0170, rebased |
|
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a socket open fails it musn't be treated as fatal error. Returning
a device error which is then handled by an application is the correct
solution. Assumed recovery action is to disconnect and then reconnect on the used Wi-Fi base station.
Pull request type
Reviewers
@SeppoTakalo
@teetak01