Skip to content

FLASH test: skip test if test region overlaps code #9258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 21, 2019
Merged

FLASH test: skip test if test region overlaps code #9258

merged 1 commit into from
Jan 21, 2019

Conversation

jeromecoutant
Copy link
Collaborator

Description

Got issue with FLASH test with NUCLEO_F410RB target in GCC only

I need to add the same king of test region check as in FLASHIAP tests.

Thx

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@ciarmcom ciarmcom requested a review from a team January 4, 2019 16:00
@ciarmcom
Copy link
Member

ciarmcom commented Jan 4, 2019

@jeromecoutant, thank you for your changes.
@ARMmbed/mbed-os-hal @ARMmbed/mbed-os-test @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested review from a team January 4, 2019 16:00
@jeromecoutant
Copy link
Collaborator Author

What about this PR ?
Thx

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 18, 2019

In this case, @ARMmbed/mbed-os-storage shall review this change

@0xc0170 0xc0170 requested review from a team and removed request for a team January 18, 2019 13:45
davidsaada
davidsaada approved these changes Jan 18, 2019
View reviewed changes
Copy link
Contributor

@davidsaada davidsaada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 18, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 19, 2019

Test run: SUCCESS

Summary: 9 of 9 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 27cce81 into ARMmbed:master Jan 21, 2019
@jeromecoutant jeromecoutant deleted the PR_FLASHSKIP branch January 21, 2019 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@davidsaada davidsaada davidsaada approved these changes

Assignees
No one assigned
Labels
release-version: 5.11.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jeromecoutant @ciarmcom @0xc0170 @mbed-ci @cmonr @davidsaada