Fix max_keys reset limitation #9054
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@theamirocohen, thank you for your changes. |
|
@theamirocohen Can you add more details to the commit msg ? The fix does not look that trivial. cc @NeilMacMullen for review |
|
I set this to 5.12 but I noticed this is updating private method, so no functional change there (fix can go to the next patch) ? |
Yes, fix can go to next patch |
Persist the max_keys value through a soft-reset, also prohibit max_keys set under predefined default value (16)
theamirocohen
force-pushed
the
nvstore_max_keys
branch
from
2dfff96 to
eff5227
Compare
0xc0170
approved these changes
Dec 12, 2018
|
CI started |
Test run: FAILEDSummary: 1 of 11 test jobs failed Failed test jobs:
|
|
Interesting. Error indicates that the NRF52_DK failed to flash. CI job restarted: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue NvStore does not correctly persist values through reset
Resolves #8785
The former NvStore implementation did not persist the max_keys value through a soft-reset, a set value would have disappear after reset, meaning NvStore would start over with its default max_keys value which may cause data to be lost.
We added the max_keys value to master record (written to non volatile area) so we can read and update its value after reset.
Furthermore we added the restriction of setting max_keys to be bigger than the default predefined keys value (16), and in case we have set max_keys to a new value and want to set it again to a smaller value the operation will fail if there are keys that might be lost (if keys were store at that gap).