-
Notifications
You must be signed in to change notification settings - Fork 3k
Release candidate for mbed-os-5.10.4 #8775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/morph build |
/morph mbed2-release |
Build : FAILUREBuild number : 3644 |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
|
Currently the following commands in examples.py, do_import() do_deploy() do_versionning() do_clone() all return a success status (ie 0) irrespective of any errors originating from their sub-functions. This PR fixes this. Now these commands will return one of: 0 - success 1 - general failure x - failure returned by a subprocess.call function
subprocess.call() does not by default return a status value. Update the commands to add shell=True which forces a return value. Also convert the commands to a single string rather than a list as this plays more nicely with both linux and windows. Also fix a spurious :
Make minor copy edits for active voice, branding and deletion of extra spaces.
If read timeout happens, the _deselect will get called twice causing a hard fault happening when mutex is released without being locked. The SDBlockDevice::read is calling the _deselect in every case.
### Description The prior fix assume that the dependencies through `.lib` references would have a "sane" name. My definition of "sane" here is that the reference will have a path that starts with the path to the `.lib` file and _removes_ the `.lib` suffix. The online compiler does not remove the `.lib` suffix. Instead, it keeps it. This makes the string replacement in the prior PR fail. Also, this is faster, and simpler. ### Pull request type [x] Fix [ ] Refactor [ ] Target update [ ] Functionality change [ ] Docs update [ ] Test update [ ] Breaking change
### Description Ignored directories are collected for the sake of exporters that use a blacklist-style approach similar to these build tools. This ignore list will include `/filer/<gibberish>` when exported from the online Compiler. This patch fixes that behavoir. ### Pull request type [x] Fix [ ] Refactor [ ] Target update [ ] Functionality change [ ] Docs update [ ] Test update [ ] Breaking change
No FPU option is valid, but supported only for 8.x releases, with 7.x release +nofp gives build errors.
306d32d
to
40a538f
Compare
/morph build |
/morph mbed2-release |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
|
Build : SUCCESSBuild number : 3646 Triggering tests/morph test |
Testing an idea. |
Neat. Forced the new job green for the time being. |
Exporter Build : SUCCESSBuild number : 3253 |
Test : FAILUREBuild number : 3425 |
The test that is the bane of my existence... Restarting. |
Test : SUCCESSBuild number : 3427 |
/morph pipeline |
No description provided.