Skip to content

Export: Remove DS-5 #8590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2018
Merged

Export: Remove DS-5 #8590

merged 1 commit into from
Nov 8, 2018

Conversation

theotherjimmy
Copy link
Contributor

Description

The DS-5 exporter does not work. It exports projects which I'm 100% sure
don't build. I have been looking over supporting it for about 6 months
now and I have convinced myself that I don't think it's worth the
trouble. Shout now if you need this exporter.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[x] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

### Description

The DS-5 exporter does not work. It exports projects which I'm 100% sure
don't build. I have been looking over supporting it for about 6 months
now and I have convinced myself that I don't think it's worth the
trouble. Shout now if you need this exporter.

### Pull request type

    [ ] Fix
    [ ] Refactor
    [ ] Target update
    [x] Functionality change
    [ ] Docs update
    [ ] Test update
    [ ] Breaking change
@0xc0170 0xc0170 requested review from bulislaw, ashok-rao and a team October 30, 2018 14:44
@0xc0170
Copy link
Contributor

0xc0170 commented Oct 30, 2018

Review please @ARMmbed/team-renesas @ARMmbed/team-nxp @ARMmbed/team-ublox (targets that were supported)

Copy link
Member

@bulislaw bulislaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it was broken for long time and the sky did not fall on our heads, I'm happy to see it go. I'm more interested in keeping small number of well supported exporters that people use than huge number of barely working ones that are not used much.

@ashok-rao
Copy link
Contributor

So far I (personally) haven't seen any major requirements from partners for DS-5 exports. However, since this is affecting quite a lot of platforms, I'd like to tag:
@toyowata @maclobdell @screamerbg for inputs as well whether there is any dependency on DS-5 exporters and also to make relevant teams at partners aware of the deprecation.

cc @MarceloSalazar

Copy link
Contributor

@ashok-rao ashok-rao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there needs to be a deprecation path / communication with relevant parties before we remove support. Needs more discussion in my view.

@toyowata
Copy link
Contributor

My partners are using uvision, vscode and e2studio exporter, but not DS-5.

@cmonr
Copy link
Contributor

cmonr commented Oct 31, 2018

@ashok-rao A question to ponder.

If the most relevant parties are not using the feature, does it need to folllow the path of deprecation?

Also an open question for @ARMmbed/mbed-os-maintainers

@RobMeades
Copy link
Contributor

Though we do use DS-5 in some areas, we never use it with mbed-os as far as I am aware, so u-blox is OK with removing it to keep your lives simple.

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 31, 2018

I think there needs to be a deprecation path / communication with relevant parties before we remove support. Needs more discussion in my view.

If the most relevant parties are not using the feature, does it need to folllow the path of deprecation?

Also +1 for being deprecated first (seeing deprecated warning for one feature release). As result, park this for post 5.11 where it can land for 5.12.

@theotherjimmy
Copy link
Contributor Author

@0xc0170 The exporter produces project files that can't build.

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 5, 2018

Even if broken for some time, I would rather have it fixed.
However as this has not been used for months (no bug report) with very limited support. OK to have it removed if others are also fine with it.

@theotherjimmy
Copy link
Contributor Author

Even if broken for some time, I would rather have it fixed.

And I would rather not have to maintain another exporter, because it invariably falls to me.

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 6, 2018

I believe we gathered sufficient feedback , entering CI

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 7, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Nov 7, 2018

Build : SUCCESS

Build number : 3572
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8590/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Nov 7, 2018

@cmonr cmonr added the rollup PR label Nov 8, 2018
@mbed-ci
Copy link

mbed-ci commented Nov 8, 2018

@cmonr
Copy link
Contributor

cmonr commented Nov 8, 2018

Note: This PR is now a part of a rollup PR (#8675).

Jenkins CI export nodes experienced many drops throughout the day causing false failures. In an attempt to get those PRs through CI, while keeping CI load low, several PRs have been bundled into a single rollup PR.

If any more commits are made in this PR, this PR will remain open and have to go through CI on its own.

@0xc0170 0xc0170 mentioned this pull request Nov 8, 2018
@cmonr cmonr merged commit f366c25 into ARMmbed:master Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants