-
Notifications
You must be signed in to change notification settings - Fork 3k
Export: Remove DS-5 #8590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export: Remove DS-5 #8590
Conversation
### Description The DS-5 exporter does not work. It exports projects which I'm 100% sure don't build. I have been looking over supporting it for about 6 months now and I have convinced myself that I don't think it's worth the trouble. Shout now if you need this exporter. ### Pull request type [ ] Fix [ ] Refactor [ ] Target update [x] Functionality change [ ] Docs update [ ] Test update [ ] Breaking change
Review please @ARMmbed/team-renesas @ARMmbed/team-nxp @ARMmbed/team-ublox (targets that were supported) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it was broken for long time and the sky did not fall on our heads, I'm happy to see it go. I'm more interested in keeping small number of well supported exporters that people use than huge number of barely working ones that are not used much.
So far I (personally) haven't seen any major requirements from partners for DS-5 exports. However, since this is affecting quite a lot of platforms, I'd like to tag: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there needs to be a deprecation path / communication with relevant parties before we remove support. Needs more discussion in my view.
My partners are using uvision, vscode and e2studio exporter, but not DS-5. |
@ashok-rao A question to ponder. If the most relevant parties are not using the feature, does it need to folllow the path of deprecation? Also an open question for @ARMmbed/mbed-os-maintainers |
Though we do use DS-5 in some areas, we never use it with mbed-os as far as I am aware, so u-blox is OK with removing it to keep your lives simple. |
Also +1 for being deprecated first (seeing deprecated warning for one feature release). As result, park this for post 5.11 where it can land for 5.12. |
@0xc0170 The exporter produces project files that can't build. |
Even if broken for some time, I would rather have it fixed. |
And I would rather not have to maintain another exporter, because it invariably falls to me. |
I believe we gathered sufficient feedback , entering CI |
/morph build |
Build : SUCCESSBuild number : 3572 Triggering tests/morph test |
Exporter Build : FAILUREBuild number : 3183 |
Test : SUCCESSBuild number : 3352 |
Note: This PR is now a part of a rollup PR (#8675). Jenkins CI export nodes experienced many drops throughout the day causing false failures. In an attempt to get those PRs through CI, while keeping CI load low, several PRs have been bundled into a single rollup PR. If any more commits are made in this PR, this PR will remain open and have to go through CI on its own. |
Description
The DS-5 exporter does not work. It exports projects which I'm 100% sure
don't build. I have been looking over supporting it for about 6 months
now and I have convinced myself that I don't think it's worth the
trouble. Shout now if you need this exporter.
Pull request type