-
Notifications
You must be signed in to change notification settings - Fork 3k
Support erase value in Flash HAL drivers, FlashIAP and block devices #8589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cc @ARMmbed/team-st-mcd @ARMmbed/team-silabs @ARMmbed/team-nxp @ARMmbed/team-realtek @ARMmbed/team-renesas @ARMmbed/team-toshiba |
/morph build |
Build : FAILUREBuild number : 3551 |
@davidsaada Some build failures indicate missing flash HAL implementations, please review |
42296e2
to
5b2f21d
Compare
Thanks @0xc0170. Should be OK now. |
/morph build |
Build : FAILUREBuild number : 3559 |
5b2f21d
to
542744d
Compare
Should really be OK now. |
/morph build |
Build : SUCCESSBuild number : 3570 Triggering tests/morph test |
Exporter Build : FAILUREBuild number : 3179 |
Test : SUCCESSBuild number : 3350 |
Note: This PR is now a part of a rollup PR (#8675). Jenkins CI export nodes experienced many drops throughout the day causing false failures. In an attempt to get those PRs through CI, while keeping CI load low, several PRs have been bundled into a single rollup PR. If any more commits are made in this PR, this PR will remain open and have to go through CI on its own. |
/morph export-build |
Exporter Build : SUCCESSBuild number : 3191 |
@@ -134,4 +134,12 @@ void flash_set_target_config(flash_t *obj) | |||
} | |||
|
|||
#endif // #if defined (__ARM_FEATURE_CMSE) && (__ARM_FEATURE_CMSE == 3U) | |||
|
|||
MBED_NONSECURE_ENTRY uint8_t flash_get_erase_value(const flash_t *obj) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
flash_get_erase_value is added her as non-secure entry function. May I know why this API is different than rest of the API's in file?
It is causing build failures in generating secure side library :-(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CC @ARMmbed/mbed-os-maintainers @ARMmbed/team-nuvoton
Description
This change adds support for getting the flash erase value in HAL drivers (all), FlashIAP driver and FlashIAP block device. It is required for the case upper layers need to check whether a flash area is erased or not. The vast majority of flash components produce the all ones (0xFF) value following an erase, and this includes all components currently supported by mbed-os. However, this change allows the addition of other components with different erase values (such as 0).
Resolves #6405.
Pull request type